System.Data.SQLite
Check-in [5dd4d355c7]
Not logged in

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Do not use internal when private can be used instead.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | tkt-1f7bfff467
Files: files | file ages | folders
SHA1: 5dd4d355c78b5a18423ea9b377af5564fb8e9f75
User & Date: mistachkin 2016-10-28 21:17:13
Context
2016-10-28
21:19
Minor correction to the previous check-in. check-in: 597c25de3b user: mistachkin tags: tkt-1f7bfff467
21:17
Do not use internal when private can be used instead. check-in: 5dd4d355c7 user: mistachkin tags: tkt-1f7bfff467
21:09
Update master release archive manifest. check-in: 123f40dc30 user: mistachkin tags: tkt-1f7bfff467
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to System.Data.SQLite/SQLiteTransaction.cs.

    19     19       /// </summary>
    20     20       public sealed class SQLiteTransaction : DbTransaction
    21     21       {
    22     22           /// <summary>
    23     23           /// The connection to which this transaction is bound
    24     24           /// </summary>
    25     25           internal SQLiteConnection _cnn;
    26         -        internal int _version; // Matches the version of the connection
           26  +
           27  +        /// <summary>
           28  +        /// Matches the version of the connection.
           29  +        /// </summary>
           30  +        private int _version;
           31  +
           32  +        /// <summary>
           33  +        /// The isolation level for this transaction.
           34  +        /// </summary>
    27     35           private IsolationLevel _level;
           36  +
           37  +        ///////////////////////////////////////////////////////////////////////////////////////////////
    28     38   
    29     39           /// <summary>
    30     40           /// Constructs the transaction object, binding it to the supplied connection
    31     41           /// </summary>
    32     42           /// <param name="connection">The connection to open a transaction on</param>
    33     43           /// <param name="deferredLock">TRUE to defer the writelock, or FALSE to lock immediately</param>
    34     44           internal SQLiteTransaction(SQLiteConnection connection, bool deferredLock)
................................................................................
   224    234           /// <summary>
   225    235           /// Issue a ROLLBACK command against the database connection,
   226    236           /// optionally re-throwing any caught exception.
   227    237           /// </summary>
   228    238           /// <param name="throwError">
   229    239           /// Non-zero to re-throw caught exceptions.
   230    240           /// </param>
   231         -        internal void IssueRollback(bool throwError)
          241  +        private void IssueRollback(bool throwError)
   232    242           {
   233    243               SQLiteConnection cnn = Interlocked.Exchange(ref _cnn, null);
   234    244   
   235    245               if (cnn != null)
   236    246               {
   237    247                   int level = cnn._transactionLevel;
   238    248   
................................................................................
   300    310           /// </summary>
   301    311           /// <param name="throwError">
   302    312           /// Non-zero to throw an exception if a state inconsistency is found.
   303    313           /// </param>
   304    314           /// <returns>
   305    315           /// Non-zero if this transaction is valid; otherwise, false.
   306    316           /// </returns>
   307         -        internal bool IsValid(bool throwError)
          317  +        private bool IsValid(bool throwError)
   308    318           {
   309    319               if (_cnn == null)
   310    320               {
   311    321                   if (throwError == true) throw new ArgumentNullException("No connection associated with this transaction");
   312    322                   else return false;
   313    323               }
   314    324