System.Data.SQLite

View Ticket
Login
Attach Edit New Ticket Plaintext
2013-01-01
19:32 • Closed ticket [8c1650482e]: SQLite3.GetBytes optimization plus 3 other changes artifact: 8bbf52212d user: mistachkin
2011-07-07
05:12
To avoid future confusion, the fix for [8c1650482e] should match the fix for [201128cc88]. check-in: f1f7b20cea user: mistachkin tags: trunk
04:48 • Ticket [8c1650482e] SQLite3.GetBytes optimization status still Fixed with 2 other changes artifact: 96844040a4 user: mistachkin
2011-05-24
01:40 • Fixed ticket [8c1650482e]. artifact: beca12706f user: shane
01:39
Minor optimization to GetBytes() to avoid calling sqlite3_column_blob() on null destination buffers. Fix for [8c1650482e]. check-in: a97d149d1e user: shaneh tags: trunk
01:25 • Ticket [8c1650482e] SQLite3.GetBytes optimization status still Open with 3 other changes artifact: 857e754cdc user: shane
2011-02-16
09:34 • New ticket [8c1650482e]. artifact: 8535247bea user: anonymous
Ticket Hash: 8c1650482e39e01446f1907d86577e4ce740d27e
Title: SQLite3.GetBytes optimization
Status: Closed Type: Code_Defect
Severity: Minor Priority: Immediate
Subsystem: Integration_Via_PInvoke Resolution: Fixed
Last Modified: 2013-01-01 19:32:05
Version Found In:
Description:
current: 
nlen = UnsafeNativeMethods.sqlite3_column_bytes(stmt._sqlite_stmt, index);
ptr = UnsafeNativeMethods.sqlite3_column_blob(stmt._sqlite_stmt, index);
if (bDest == null) return nlen;

need: 

nlen = UnsafeNativeMethods.sqlite3_column_bytes(stmt._sqlite_stmt, index);
if (bDest == null) return nlen;


if (nCopied + nStart > bDest.Length) nCopied = bDest.Length - nStart;
if (nCopied + nDataOffset > nlen) nCopied = nlen - nDataOffset;


if (nCopied > 0) {
    ptr = UnsafeNativeMethods.sqlite3_column_blob(stmt._sqlite_stmt, index);
    Marshal.Copy((IntPtr)(ptr.ToInt64() + nDataOffset), bDest, nStart, nCopied);
} else nCopied = 0;

shane added on 2011-05-24 01:40:06 UTC:
Fixed by [a97d149d1e].

mistachkin added on 2011-07-07 04:48:39 UTC:
Related to [201128cc88].