Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | When creating MockRegistryKey objects, use the new constructors that require the readOnly and safe arguments. |
---|---|
Downloads: | Tarball | ZIP archive |
Timelines: | family | ancestors | descendants | both | trunk |
Files: | files | file ages | folders |
SHA1: |
64686e66852123e28b4822df0ad41d47 |
User & Date: | mistachkin 2011-12-13 10:09:42.066 |
Context
2011-12-16
| ||
03:28 | Add missing file header to various files. check-in: f58dc30e00 user: mistachkin tags: trunk | |
2011-12-13
| ||
10:09 | When creating MockRegistryKey objects, use the new constructors that require the readOnly and safe arguments. check-in: 64686e6685 user: mistachkin tags: trunk | |
09:42 | More improvements to the VS designer component installer. check-in: c8cae6af9e user: mistachkin tags: trunk | |
Changes
Changes to tools/install/Installer.cs.
︙ | ︙ | |||
526 527 528 529 530 531 532 | // fails, we will simply return the wrapped root key // itself since no writes are allowed in 'what-if' // mode anyhow. // RegistryKey subKey = key.OpenSubKey(subKeyName); return (subKey != null) ? | | > | > | | 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 | // fails, we will simply return the wrapped root key // itself since no writes are allowed in 'what-if' // mode anyhow. // RegistryKey subKey = key.OpenSubKey(subKeyName); return (subKey != null) ? new MockRegistryKey( subKey, whatIf, readOnly, safe) : new MockRegistryKey( key, subKeyName, whatIf, readOnly, safe); } else { return new MockRegistryKey( key.CreateSubKey(subKeyName), whatIf, readOnly, safe); } } /////////////////////////////////////////////////////////////////// public void DeleteSubKey( string subKeyName |
︙ | ︙ | |||
641 642 643 644 645 646 647 | if (key == null) return null; RegistryKey subKey = key.OpenSubKey( subKeyName, whatIf ? false : writable); return (subKey != null) ? | | | 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 | if (key == null) return null; RegistryKey subKey = key.OpenSubKey( subKeyName, whatIf ? false : writable); return (subKey != null) ? new MockRegistryKey(subKey, whatIf, readOnly, safe) : null; } /////////////////////////////////////////////////////////////////// public void SetValue( string name, object value |
︙ | ︙ | |||
772 773 774 775 776 777 778 | // BUGBUG: The 'what-if' mode setting here should probably be based // on some static property, not hard-coded to true? // public static implicit operator MockRegistryKey( RegistryKey key ) { | | | 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 | // BUGBUG: The 'what-if' mode setting here should probably be based // on some static property, not hard-coded to true? // public static implicit operator MockRegistryKey( RegistryKey key ) { return new MockRegistryKey(key, null, true, false, false); } /////////////////////////////////////////////////////////////////// // // BUGBUG: Remove me? This should be safe because in 'what-if' // mode all keys are opened read-only. |
︙ | ︙ | |||
957 958 959 960 961 962 963 | // HACK: Always forbid writable access when operating in // 'what-if' mode. // MockRegistryKey key = rootKey.OpenSubKey( subKeyName, whatIf ? false : writable); return (key != null) ? | | | 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 | // HACK: Always forbid writable access when operating in // 'what-if' mode. // MockRegistryKey key = rootKey.OpenSubKey( subKeyName, whatIf ? false : writable); return (key != null) ? new MockRegistryKey(key, whatIf, false, false) : null; } /////////////////////////////////////////////////////////////////// public static MockRegistryKey CreateSubKey( MockRegistryKey rootKey, string subKeyName, |
︙ | ︙ | |||
994 995 996 997 998 999 1000 | // this fails, we will simply return the root key // itself since no writes are allowed in // 'what-if' mode anyhow. // MockRegistryKey key = rootKey.OpenSubKey(subKeyName); return (key != null) ? | | > | > | 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 | // this fails, we will simply return the root key // itself since no writes are allowed in // 'what-if' mode anyhow. // MockRegistryKey key = rootKey.OpenSubKey(subKeyName); return (key != null) ? key : new MockRegistryKey( rootKey, subKeyName, true, false, false); } else { return new MockRegistryKey( rootKey.CreateSubKey(subKeyName), false, false, false); } } finally { subKeysCreated++; } } |
︙ | ︙ |