Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | Explicitly dispose of all the commands associated with a SQLiteDataAdapter object as the base class does not do it. Fix for ticket [6434e23a0f]. |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA1: |
42d873a6d820f80b298a10cec9142e28 |
| User & Date: | mistachkin 2013-01-09 18:50:19 |
Context
|
2013-01-09
| ||
| 19:18 | Preparation for the 1.0.84.0 release. check-in: 060593ee6a user: mistachkin tags: trunk | |
| 18:50 | Explicitly dispose of all the commands associated with a SQLiteDataAdapter object as the base class does not do it. Fix for ticket [6434e23a0f]. check-in: 42d873a6d8 user: mistachkin tags: trunk | |
| 02:11 | Add Visual Studio 2012 / .NET Framework 4.5 specific binaries to the NuGet packages. Add a NuGet package specifically for beta testing purposes. check-in: 6d3a6e6ae3 user: mistachkin tags: trunk | |
Changes
Changes to System.Data.SQLite/SQLiteDataAdapter.cs.
| ︙ | ︙ | |||
80 81 82 83 84 85 86 |
protected override void Dispose(bool disposing)
{
try
{
if (!disposed)
{
| | < > | | | | > > > > > > > > > > > > > > > > > > > > > > > > | 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 |
protected override void Dispose(bool disposing)
{
try
{
if (!disposed)
{
if (disposing)
{
////////////////////////////////////
// dispose managed resources here...
////////////////////////////////////
if (SelectCommand != null)
{
SelectCommand.Dispose();
SelectCommand = null;
}
if (InsertCommand != null)
{
InsertCommand.Dispose();
InsertCommand = null;
}
if (UpdateCommand != null)
{
UpdateCommand.Dispose();
UpdateCommand = null;
}
if (DeleteCommand != null)
{
DeleteCommand.Dispose();
DeleteCommand = null;
}
}
//////////////////////////////////////
// release unmanaged resources here...
//////////////////////////////////////
disposed = true;
}
|
| ︙ | ︙ |
Added Tests/tkt-6434e23a0f.eagle.
> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 |
###############################################################################
#
# tkt-6434e23a0f.eagle --
#
# Written by Joe Mistachkin.
# Released to the public domain, use at your own risk!
#
###############################################################################
package require Eagle
package require Eagle.Library
package require Eagle.Test
runTestPrologue
###############################################################################
package require System.Data.SQLite.Test
runSQLiteTestPrologue
###############################################################################
runTest {test tkt-6434e23a0f-1.1 {SQLiteDataAdapter command disposal} -setup {
setupDb [set fileName tkt-6434e23a0f-1.1.db]
} -body {
sql execute $db "CREATE TABLE t1(x);"
sql execute $db "INSERT INTO t1 (x) VALUES(1);"
sql execute $db "INSERT INTO t1 (x) VALUES(2);"
cleanupDb $fileName db true false false
set id [object invoke Interpreter.GetActive NextId]
set dataSource [file join [getDatabaseDirectory] $fileName]
set sql { \
SELECT x FROM t1; \
}
unset -nocomplain results errors
set code [compileCSharpWith [subst {
using System.Data;
using System.Data.SQLite;
using System.IO;
namespace _Dynamic${id}
{
public static class Test${id}
{
public static void Main()
{
using (SQLiteConnection connection = new SQLiteConnection(
"Data Source=${dataSource};"))
{
connection.Open();
using (SQLiteDataAdapter dataAdapter = new SQLiteDataAdapter(
"${sql}", connection))
{
dataAdapter.Fill(new DataSet());
}
}
File.Delete("${dataSource}");
}
}
}
}] true true true results errors System.Data.SQLite.dll]
list $code $results \
[expr {[info exists errors] ? $errors : ""}] \
[expr {$code eq "Ok" ? [catch {
object invoke _Dynamic${id}.Test${id} Main
} result] : [set result ""]}] $result
} -cleanup {
cleanupDb $fileName
unset -nocomplain result results errors code sql dataSource id db fileName
} -constraints \
{eagle monoBug28 command.sql compile.DATA SQLite System.Data.SQLite} -match \
regexp -result {^Ok System#CodeDom#Compiler#CompilerResults#\d+ \{\} 0 \{\}$}}
###############################################################################
runSQLiteTestEpilogue
runTestEpilogue
|