System.Data.SQLite
Check-in [ca6b82074a]
Not logged in

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:The SetConfigurationOption method needs to throw an exception when the core library result code indicates an error.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: ca6b82074a11c3dccb6b6136434f427ec119ca60
User & Date: mistachkin 2018-02-26 20:23:44
Context
2018-02-26
21:31
Make the (new) SetConfigurationOption tests more robust and get them passing again. check-in: 550a609491 user: mistachkin tags: trunk
20:23
The SetConfigurationOption method needs to throw an exception when the core library result code indicates an error. check-in: ca6b82074a user: mistachkin tags: trunk
19:31
Enhancements to tests added by the previous check-in. check-in: e2dffd3a80 user: mistachkin tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to System.Data.SQLite/SQLiteConnection.cs.

3728
3729
3730
3731
3732
3733
3734
3735



3736
3737
3738
3739
3740
3741
3742

        if ((option == SQLiteConfigDbOpsEnum.SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION) &&
            ((_flags & SQLiteConnectionFlags.NoLoadExtension) == SQLiteConnectionFlags.NoLoadExtension))
        {
            throw new SQLiteException("Loading extensions is disabled for this database connection.");
        }

        _sql.SetConfigurationOption(option, value);



    }

    /// <summary>
    /// Enables or disabled extension loading.
    /// </summary>
    /// <param name="enable">
    /// True to enable loading of extensions, false to disable.







|
>
>
>







3728
3729
3730
3731
3732
3733
3734
3735
3736
3737
3738
3739
3740
3741
3742
3743
3744
3745

        if ((option == SQLiteConfigDbOpsEnum.SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION) &&
            ((_flags & SQLiteConnectionFlags.NoLoadExtension) == SQLiteConnectionFlags.NoLoadExtension))
        {
            throw new SQLiteException("Loading extensions is disabled for this database connection.");
        }

        SQLiteErrorCode rc = _sql.SetConfigurationOption(option, value);

        if (rc != SQLiteErrorCode.Ok)
            throw new SQLiteException(rc, null);
    }

    /// <summary>
    /// Enables or disabled extension loading.
    /// </summary>
    /// <param name="enable">
    /// True to enable loading of extensions, false to disable.