System.Data.SQLite: Check-in [4fbdb092f8]

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview

Comment:	Correction to the previous commit. Actually, instead of throwing exceptions directly, always attempt to convert non-null values to the required type and let the converter itself throw an exception if necessary.
Downloads:	Tarball \| ZIP archive \| SQL archive
Timelines:	family \| ancestors \| descendants \| both \| trunk
Files:	files \| file ages \| folders
SHA1:	4fbdb092f88272935f1085428df8723f9338822e
User & Date:	mistachkin 2011-12-20 00:07:49

References

2011-12-20
00:09		• Closed ticket [f3ec1e0066]: Please set DateTime.Kind property when reading values plus 2 other changes artifact: 367f28df83 user: mistachkin

Context

2011-12-20
04:38		More testing of the SQLiteConnectionStringBuilder class. Modify anchor names in the release procedures wiki page. check-in: 6853b38030 user: mistachkin tags: trunk
00:07		Correction to the previous commit. Actually, instead of throwing exceptions directly, always attempt to convert non-null values to the required type and let the converter itself throw an exception if necessary. check-in: 4fbdb092f8 user: mistachkin tags: trunk
00:05		Throw an exception if an unsupported object type is detected in the DateTimeFormat property. check-in: 68b19e5f02 user: mistachkin tags: trunk

Changes

Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to System.Data.SQLite/SQLiteConnectionStringBuilder.cs.

        {
            object value;

            if (TryGetValue("datetimeformat", out value))
            {
                if (value is SQLiteDateFormats)
                    return (SQLiteDateFormats)value;
                else if (value is string)
                    return (SQLiteDateFormats)TypeDescriptor.GetConverter(
                        typeof(SQLiteDateFormats)).ConvertFrom(value);
                else
                    throw new NotSupportedException();
            }

            return SQLiteDateFormats.Default;
        }
        set
        {
            this["datetimeformat"] = value;
................................................................................
        {
            object value;

            if (TryGetValue("datetimekind", out value))
            {
                if (value is DateTimeKind)
                    return (DateTimeKind)value;
                else if (value is string)
                    return (DateTimeKind)TypeDescriptor.GetConverter(
                        typeof(DateTimeKind)).ConvertFrom(value);
                else
                    throw new NotSupportedException();
            }

            return DateTimeKind.Unspecified;
        }
        set
        {
            this["datetimekind"] = value;

        {
            object value;

            if (TryGetValue("datetimeformat", out value))
            {
                if (value is SQLiteDateFormats)
                    return (SQLiteDateFormats)value;
                else if (value != null)
                    return (SQLiteDateFormats)TypeDescriptor.GetConverter(
                        typeof(SQLiteDateFormats)).ConvertFrom(value);


            }

            return SQLiteDateFormats.Default;
        }
        set
        {
            this["datetimeformat"] = value;
................................................................................
        {
            object value;

            if (TryGetValue("datetimekind", out value))
            {
                if (value is DateTimeKind)
                    return (DateTimeKind)value;
                else if (value != null)
                    return (DateTimeKind)TypeDescriptor.GetConverter(
                        typeof(DateTimeKind)).ConvertFrom(value);


            }

            return DateTimeKind.Unspecified;
        }
        set
        {
            this["datetimekind"] = value;