D 2011-07-07T04:36:26.145
J comment In\sthis\scode:\r\n\r\n\s\r\n<verbatim>\r\n\s\s\s\s\s\s\s\s\s\s\s\sdefValue\s=\sFindKey(opts,\s"Journal\sMode",\s"Delete");\r\n\s\s\s\s\s\s\s\s\s\s\s\sif\s(String.Compare(defValue,\s"Default",\sStringComparison.OrdinalIgnoreCase)\s!=\s0)\r\n\s\s\s\s\s\s\s\s\s\s\s\s{\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\scmd.CommandText\s=\sString.Format(CultureInfo.InvariantCulture,\s"PRAGMA\sjournal_mode={0}",\sdefValue);\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\scmd.ExecuteNonQuery();\r\n\s\s\s\s\s\s\s\s\s\s\s\s}\r\n</verbatim>\r\n\r\n\s\r\n\r\nshouldn't\s"Default"\sbe\s"Delete"?\sThere\smight\sbe\ssome\sother\scompares\sthat\sare\swrong.\n\n<hr\s/><i>anonymous\sclaiming\sto\sbe\snavaraf\sadded\son\s2011-02-17\s09:58:09\sUTC:</i><br\s/>\nActually\sI\sbelieve\sthe\slast\sparameter\sto\sFindKey\sshould\sbe\s"Default",\snot\s"Delete".\n\n<hr\s/><i>anonymous\sadded\son\s2011-02-17\s14:56:18\sUTC:</i><br\s/>\nI\sagree,\sit\sshould\scheck\sfor\s"Default",\snot\s"Delete".\s\sAn\sexplanation:\r\n\r\nConsider\sthe\scase\sof\san\sexisting\sdatabase\swith\sa\sjournal\smode\sset\sto\ssomething\sother\sthan\sdelete\s(esp.\sWAL).\s\sConnecting\swith\sthe\sjournal\smode\sexplicitly\sset\sto\sdelete\sshould\schange\sthe\sjournal\smode,\sor\sat\sleast\sattempt\sto.\r\n\r\nIf\sthe\sconnection\sstring\shandling\schecks\sfor\s"Delete"\sas\sthe\sdo-nothing\sdefault,\sthen\sthat\sscenario\swould\snot\swork\sproperly.\n\n<hr\s/><i>mistachkin\sadded\son\s2011-07-05\s06:24:37\sUTC:</i><br\s/>\nFixed\swith\s[50b4844f0c].
J subsystem Connection
K 2a0c90d7b09cc2ff5fb401a84ad7344cd1e4867d
U mistachkin
Z f98255b2fa2efd9d90e96263e13189c1
